-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Fix aspect ratio for flat maps #4184
base: main
Are you sure you want to change the base?
Conversation
👋 @ymzayek Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4184 +/- ##
==========================================
+ Coverage 91.85% 91.91% +0.05%
==========================================
Files 144 145 +1
Lines 16419 16708 +289
Branches 3434 3552 +118
==========================================
+ Hits 15082 15357 +275
+ Misses 792 782 -10
- Partials 545 569 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Artifacts link for quick access: https://app.circleci.com/pipelines/github/nilearn/nilearn/10940/workflows/b9b505ca-e58f-45c4-9aa7-11ce2d76b77d/jobs/14134/artifacts |
Hm from what I understood in the original PR this change shouldn't affect the initial zoom with plotting in standard space with |
Also in the EDIT: fixed in 0ddd103 |
@jeromedockes can you reproduce this https://github.com/nilearn/nilearn/pull/2899/files#r690337773 in this pr? |
Ok I see, the problem sems to be with |
Changes proposed in this pull request:
plot_surf
andview_surf