Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtkgui: async rows #2952

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

slook
Copy link
Member

@slook slook commented Mar 21, 2024

Superseeds PR #2917 to close issue #2910

GTK is single-threaded. You'd need to implement something like ... adding rows in batches (currently, only user browse works somewhat, but there are several edge cases you need to handle).

not fully tested.

@slook slook mentioned this pull request Mar 21, 2024
@slook
Copy link
Member Author

slook commented Mar 21, 2024

When browsing a user's saved list the progress bar disappears before the tree is fully loaded and it's possible to navigate the folder tree view while items are still being added to it, which is feels great but the progress bar doesn't indicate that this is happening.

@mathiascode mathiascode marked this pull request as draft March 21, 2024 21:52
@mathiascode
Copy link
Member

I'd like to prioritize the port to GtkColumnView, which will fix the performance issues for GTK 4 users without the need for this PR. I might continue working on this, but I'm not sure, considering GTK 4 is turning 4 years old, and we want to phase out GTK 3 eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants