ChatView: use explicit username in append_line() #2792
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slook
force-pushed
the
chatview-append-line-message-text
branch
from
830e488
to
8b3eaed
Compare
slook
changed the title
slook
force-pushed
the
chatview-append-line-message-text
branch
from
8b3eaed
to
ec8df96
Compare
slook
force-pushed
the
chatview-append-line-message-text
branch
from
ec8df96
to
5731c70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-urgent. Not required until 3.3.1+
find()when inserting text for online chat messages.roomnamein preparation for closing first point in Public chat room feed: Don't notify on new messages + clickable room names #2482formatted_messageas it is not part of the protocol.Requires improvement of
timestampdata type mixing string vs. integer.Reference draft PR #2540