Silent mode, no cexpr if no violation is found #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beatgutzwiller
force-pushed
the
master
branch
from
a4c9669
to
8ce978b
Compare
|
can this made it to master? I need this |
I think this repo is not updated anymore. There are 37 Forks. Choose one with the right fix. I use mine but I am fairly certain there are better! |
|
alright @beatgutzwiller thanks 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you use rubocop -a as autocmd on save, it will always open a cexpr.
This is quite irritating. This commits add a silent flag (--silent, -s) to supress this behaviour.
Also it prevents the cexpr to be shown if no violation is found, and shows a message instead.
In my opinion this should always be on, since it is useless to open an empty cexpr. But feel free to make it configurable if wanted.