Move extra_args to the end of the rubocop command #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some rubocop executables, a `--file` or `--path` option might be necessary to target a specific file to run the parser. This currently would need to be the last argument in the string to be paired up with the `l:filename` when running the RuboCop command. Swapping these arguments should retain the previous functionality just fine, while allowing for the use-case described above. Note: It was chosen to have `l:extra_args` last in the list versus `a:current_args` since a `--file` option is more useful to be applied to every command instead of on demand via the `a:current_args`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some rubocop executables, a
--fileor--pathoption might be necessary to target a specific file to run the parser. I myself use a modified form of rubocop-git (with an addition to support the flags above, as well as the--formatflag) instead of the defaultrubocopcommand to only look at offenses I have made in my branch.To allow using
rubocop-gitusing theg:vimrubocop_rubocop_cmd, the last argument in the string includes the--fileargument to be paired up with thel:filenamewhen running the:RuboCopcommand.Swapping these arguments should retain the previous functionality just fine, while allowing for the use-case described above.
Note: It was chosen to have
l:extra_argslast in the list versusa:current_argssince a--fileoption is more useful to be applied to every call of:RuboCopinstead of on-demand via thea:current_args.