Usability "upgrades" #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a consideration that I always appreciate from plugins. If someone happens to have a command that starts with `Ru` that they use with other filetypes, they can continue to simple type `:Ru` in those buffers.
hawkins
reviewed
Nov 6, 2018
plugin/rubocop.vim
Outdated
| @@ -54,8 +54,12 @@ function! s:RuboCop(current_args) | |||
| endif | |||
| let l:rubocop_output = substitute(l:rubocop_output, '\\"', "'", 'g') | |||
| let l:rubocop_results = split(l:rubocop_output, "\n") | |||
| cexpr l:rubocop_results | |||
| copen | |||
| if len(l:rubocop_results) | |||
There was a problem hiding this comment.
I think cwindow in essence does this same logic; if there are errors populated in cexpr, then it opens the cwindow if it is not opened. Else, it does nothing
There was a problem hiding this comment.
Heh, I forgot all about this PR and have been just maintaining my own fork.
cwindow doesn't work here since it's just parsing the return value of a system() call which does not populate the quickfix list.
|
These changes are great and make the plugin a lot nicer to use 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
Not sure if you will be into all these changes but I figured I'd give it a shot to get 'em merged. The overarching goal is to improve usability by condensing annoying warnings.
Thanks!