Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(settings): Move new user modal to dialog + minor refactoring #45315

Merged
merged 8 commits into from
May 31, 2024
Merged

fix(settings): Move new user modal to dialog + minor refactoring #45315

merged 8 commits into from
May 31, 2024

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented May 14, 2024

Summary

  • Move from NcModal to NcDialog to fix some style issues e.g. close button overlapping scrollbar, use built-in name heading for consistent styles
  • Some small refactors
  • Adjust "user" to "account" in dialog, will make a future followup for some of the other places
  • Autofocus username input
Before After
image image
image

Checklist

@Pytal Pytal added this to the Nextcloud 30 milestone May 14, 2024
@Pytal Pytal requested review from susnux, artonge and Fenn-CS May 14, 2024 22:21
@Pytal Pytal self-assigned this May 14, 2024
@Pytal Pytal enabled auto-merge May 14, 2024 22:22
@Pytal
Copy link
Member Author

Pytal commented May 24, 2024

Adjusted a few more places that ripgrep didn't find last time 🙈

@Pytal
Copy link
Member Author

Pytal commented May 24, 2024

/compile /

@Pytal Pytal requested a review from skjnldsv May 24, 2024 16:55
@skjnldsv

This comment was marked as resolved.

Sign in to view
@skjnldsv
Copy link
Member

Maybe fixes this #41011 ?

Pytal and others added 7 commits May 30, 2024 15:32
@Pytal
fix(settings): Move user creation modal to dialog
359003d 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
chore: Change some "user" strings to "account"
6f63ecf 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
refactor: Migrate to built-in NcSelect input label
45ba61b 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
fix: Autofocus username input
76104aa 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
refactor: Shorten input focus calls
fad49e6 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
chore: Change more "user" strings to "account"
6b583f7 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@nextcloud-command @Pytal
chore(assets): Recompile assets
f54acd5 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@Pytal
Copy link
Member Author

Pytal commented May 30, 2024

Maybe fixes this #41011 ?

Only the not closing on click outside part, other parts still open :)

@Pytal Pytal force-pushed the fix/new-user-dialog branch 2 times, most recently from c4a71cb to 8a41837 Compare May 30, 2024 23:45
@Pytal
test(cypress): Fix tests
930e47d 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal merged commit 0687853 into master May 31, 2024
104 checks passed
@Pytal Pytal deleted the fix/new-user-dialog branch May 31, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@artonge artonge Awaiting requested review from artonge

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS

Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews bug feature: users and groups
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Pytal @skjnldsv @susnux @nextcloud-command