-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(framework): add nuxt framework client #10684
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
Also use runtime configs for configuring auth
e4dbff6
to
b78106f
Compare
Followup Todos for us:
|
package.json
Outdated
@@ -56,7 +57,8 @@ | |||
"typescript": "5.3.3", | |||
"utils": "workspace:*", | |||
"vite": "^5.0.13", | |||
"vitest": "1.2.2" | |||
"vitest": "1.2.2", | |||
"vue-eslint-parser": "^9.4.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do eslint-plugin-vue
and vue-eslint-parser
need to be int he root package.json
? Ideally these would be in the framework-nuxt/package.json
instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, good point. I have moved them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On a second note: we would need this also in the apps/dev/nuxt project as well, right?
is it possible to build it and use it as alpha until the production version released ? @peterbud |
I think we are pretty early in the process of creating this framework, I'd love to have a proper review from the AuthJS core members before suggesting to use this. |
@peterbud is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
☕️ Reasoning
This PR is aiming to add support for Nuxt framework to
@AuthJS
🧢 Checklist
SetEnvDefaults
to be consistent with other frameworks🎫 Affected issues
N/A