Feat: Inviting users should store original user id not email. #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For security the id of the user inviting a new user should be stored forever, however in the previous code it would only store the email. Since the email can be changed at any time by any user you could end up with a situation where you don't know which of your users invited the new user after an email change. For slightly better application hardening lets store the id instead as it follows the user for their whole lifetime using the app.
|
@graysoncampbell is attempting to deploy a commit to the Nextacular Team on Vercel. A member of the Team first needs to authorize it. |
|
Good catch @graysoncampbell! I'll review the update. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For security the id of the user inviting a new user should be stored forever, however in the previous code it would only store the email. Since the email can be changed at any time by any user you could end up with a situation where you don't know which of your users invited the new user after an email change. For slightly better application hardening lets store the id instead as it follows the user for their whole lifetime using the app.