Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply small copyrights detection improvements #3752

Open
wants to merge 22 commits into
base: develop
Choose a base branch
from
Open

Apply small copyrights detection improvements #3752

wants to merge 22 commits into from
+1,723 −366

Conversation

pombredanne
Copy link
Member

This PR improves copyright detection

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Updated documentation pages (if applicable)
  • Updated CHANGELOG.rst (if applicable)

@pombredanne
Detect odd name in copyright #3655
c206f91 
Reported-by: Anton Augsburg @vw-anton
Reference: #3655
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Do not detect trailing Distributed in copyright #3735
54b2309 
Reported-by:  Dimitris Iliou @dimitris-iliou
Reference: #3735
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Improve misc. copyright detections
5215ef4 
Spotted in some common python libraries such as numpy and scipy

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Add new script to generate copyright tests
d1cf644 
Use an input file where each line is either:
- a URL to fetch
- a text to test

Then generate a test data files pair accordingly

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Improve copyright detection
5294521 
- Start detecting "is held by"
- Do not include some trailing junk

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Detect NN/EMAIL copyright combo #3764
ab6699f 
Reference: #3764
Reported-by: Anton Augsburg @vw-anton
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Merge remote-tracking branch 'upstream/develop' into misc-copyrights
753c492
@pombredanne
Detect NN/EMAIL copyright combo #3764
ca8efbd 
Make detection of copyright with a single lowercase name more specific

Reference: #3764
Reported-by: Anton Augsburg @vw-anton
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Align license with improved copyrights
2354701 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Improve copyright detection of "distributed"
00a9abc 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Do not detect some words as NNP
dd5de6e 
This makes copyright detection more specific

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Improve copyright tests
97d0bcb 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Detect OpenStreetMap correctly
6a9663e 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Add new copyright detection tests
12b7ace 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Improve copyright detection side-effects
0d7df58 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Enable generation of copyright test file
8b2ddf5 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Improve copyright debug tracing
1fc7cea 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Detect new form of copyright
b0a6e26 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Do not add arbitrary space around markup
7ff3f8e 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Improve handle of parens in copyright
850edc1 
Also improve NOTICEs, and other misc. variants
Don not detect "The Initial Developer"

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Correctly filter copyrights in licenses #3797
f3f2c78 
Reference: #3797
Reported-by: Jörg Arndt @Joerki
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Improve copyright detection
461fd65 
Handle corner cases with markup
Detect new copyright forms.

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@pombredanne