Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #include cpp file #2857

Merged
merged 7 commits into from Apr 29, 2024

Conversation

mgeplf
Copy link
Collaborator

@mgeplf mgeplf commented Apr 25, 2024

No description provided.

@mgeplf mgeplf marked this pull request as draft April 25, 2024 19:45
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 66.09195% with 59 lines in your changes are missing coverage. Please review.

Project coverage is 67.19%. Comparing base (8b35309) to head (a42c21e).

Files Patch % Lines
src/nrncvode/netcvode.cpp 70.79% 33 Missing ⚠️
src/parallel/ocbbs.cpp 57.37% 26 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2857      +/-   ##
==========================================
- Coverage   67.20%   67.19%   -0.01%     
==========================================
  Files         565      563       -2     
  Lines      104286   104284       -2     
==========================================
- Hits        70087    70076      -11     
- Misses      34199    34208       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Apr 27, 2024

Quality Gate Passed Quality Gate passed

Issues
59 New issues
0 Accepted issues

Measures
4 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mgeplf mgeplf marked this pull request as ready for review April 29, 2024 09:33
@pramodk pramodk requested a review from alkino April 29, 2024 10:07
@alkino alkino merged commit 13654b3 into neuronsimulator:master Apr 29, 2024
36 checks passed
@mgeplf mgeplf deleted the cleanup-include-cpp-file branch April 29, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants