New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pyproject migration #2832
Draft
JCGoran
wants to merge
15
commits into
master
Choose a base branch
from
jelic/pyproject_take2
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Pyproject migration #2832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
- modify CI so it runs cibuildwheel - modify cmakelists so it doesn't search for Python modules
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2832 +/- ##
==========================================
+ Coverage 67.14% 68.36% +1.21%
==========================================
Files 562 493 -69
Lines 104087 93440 -10647
==========================================
- Hits 69890 63877 -6013
+ Misses 34197 29563 -4634 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
Until we update the whole module
It's in the standard lib
This comment has been minimized.
This comment has been minimized.
Quality Gate passedIssues Measures |
This was referenced Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pyproject migration.
TODO list:
setup.py
cython
CLI command to build RX3D and MUSIC Python modules instead of insetup.py
(we can then use CMake for them)extra_compile_args
andextra_link_args
install_manifest.txt
)NMODL_PYLIB
not being set (only in the MacOS CI though?)project.scripts
section topyproject
(so we havenrniv
,nrnivmodl
, etc. scripts)