Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pyproject migration #2832

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from
Draft

Pyproject migration #2832

wants to merge 15 commits into from

Conversation

JCGoran
Copy link
Contributor

@JCGoran JCGoran commented Apr 11, 2024

Pyproject migration.

TODO list:

  • move docs building to a separate script instead ofsetup.py
  • replace all CLI flags with env variables (more or less done)
  • use cython CLI command to build RX3D and MUSIC Python modules instead of in setup.py (we can then use CMake for them)
  • add script to change name of project (since we can't use native utils for this)
  • figure out how to pass extra_compile_args and extra_link_args
  • fix various paths in generated wheel (see install_manifest.txt)
  • fix versioning
  • fix NMODL complaining about NMODL_PYLIB not being set (only in the MacOS CI though?)
  • add project.scripts section to pyproject (so we have nrniv, nrnivmodl, etc. scripts)

@bbpbuildbot

This comment has been minimized.

- modify CI so it runs cibuildwheel
- modify cmakelists so it doesn't search for Python modules
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.36%. Comparing base (d3d8886) to head (0727293).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2832      +/-   ##
==========================================
+ Coverage   67.14%   68.36%   +1.21%     
==========================================
  Files         562      493      -69     
  Lines      104087    93440   -10647     
==========================================
- Hits        69890    63877    -6013     
+ Misses      34197    29563    -4634     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

@bbpbuildbot

This comment has been minimized.

Copy link

sonarcloud bot commented Apr 12, 2024

Quality Gate Passed Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

This was referenced Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants