Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change volume method #2781

Merged
merged 17 commits into from May 6, 2024
Merged

change volume method #2781

merged 17 commits into from May 6, 2024

Conversation

rgourdine
Copy link
Collaborator

closes #1151

Copy link

✔️ 2ac7ce9 -> Azure artifacts URL

Copy link

sonarcloud bot commented Mar 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

✔️ 0178edb -> Azure artifacts URL

Copy link

codecov bot commented Mar 16, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 67.18%. Comparing base (0a7b890) to head (1ae5dbc).

Files Patch % Lines
share/lib/python/neuron/rxd/region.py 73.33% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2781   +/-   ##
=======================================
  Coverage   67.17%   67.18%           
=======================================
  Files         563      563           
  Lines      104283   104295   +12     
=======================================
+ Hits        70056    70066   +10     
- Misses      34227    34229    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

@alkino alkino added the rxd reaction-diffusion label Apr 9, 2024
Copy link

✔️ 166fa40 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Copy link

✔️ ee41ac4 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Copy link

✔️ cc25f9e -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Copy link

✔️ 33d82de -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

@pramodk
Copy link
Member

pramodk commented Apr 24, 2024

Just a note: neuronsimulator.nrn Azure CI can be ignored temporarily. I am changing some settings and hence it will appear as cancelled.

Copy link

✔️ 24d869e -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Copy link

✔️ cdde7c8 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Copy link

sonarcloud bot commented May 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

✔️ 1ae5dbc -> Azure artifacts URL

@ramcdougal ramcdougal merged commit d99cbb5 into master May 6, 2024
37 checks passed
@ramcdougal ramcdougal deleted the region_volume branch May 6, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rxd reaction-diffusion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

need a friendly way of getting volume of a region
5 participants