Create a pointer from Prop to Node.
#2768
Conversation
When generating code to call processes from HOC or Python one difficulty can be obtaining the voltage. The voltage is associated with the Node. In the generated code we only have access to the Prop. We don't have access to the voltage via `Memb_list::nodeindices`. When generating code for NRN with NMODL, we don't populate what CoreNEURON calls `v_unused`.
|
@nrnhines I believe we've discussed this issue in a different context. Would something like this make sense? |
|
✔️ 09b49db -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
|
I've also experienced this issue and am much in favor of this fix. |
|
✔️ 09b49db -> Azure artifacts URL |
|
Thank you! If nobody else needs it right away, I'd propose I first implement the code in NMODL that needs this. Then when that's ready for merging we also merge this first. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2768 +/- ##
==========================================
- Coverage 66.92% 66.91% -0.01%
==========================================
Files 560 560
Lines 104093 104086 -7
==========================================
- Hits 69666 69654 -12
- Misses 34427 34432 +5 ☔ View full report in Codecov by Sentry. |
When generating code to call processes from HOC or Python one difficulty can be obtaining the voltage. The voltage is associated with the Node. In the generated code we only have access to the Prop.
We don't have access to the voltage via
Memb_list::nodeindices. When generating code for NRN with NMODL, we don't populate what CoreNEURON callsv_unused.