Make MutexPool an allocator #2766
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
✔️ d72251f -> Azure artifacts URL |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2766 +/- ##
==========================================
- Coverage 67.15% 67.14% -0.01%
==========================================
Files 562 561 -1
Lines 104118 104073 -45
==========================================
- Hits 69923 69885 -38
+ Misses 34195 34188 -7 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
|
✔️ 4a12b57 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
JCGoran
reviewed
Mar 22, 2024
This comment has been minimized.
This comment has been minimized.
|
✔️ 2b1719a -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
|
✔️ 0936bef -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
|
|
✔️ cc18266 -> Azure artifacts URL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
structpool.htoutils/pool.hppMove
nrncvode/pool.hinutils/mutexed_pool.hpp.The new pools is neuron-agnostic (hoc, ...).
To create a normal pool:
Pool<int>To create a pool protected with mutex:
MutexedPool<int>, the type of the mutex can be given as a second optional argument (by default std::mutex)MutexedPool<int, std::recursive_mutex>To follow https://en.cppreference.com/w/cpp/named_req/Allocator:
alloctoallocatehpfreetodeallocateThe function to clean the data has to be set with
set_functionit lets us, use a different name, a lambda, a free function, ... compare to before where the function should be part of the type and namedclear().