Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lookup in SPTree #2759

Merged
merged 3 commits into from Feb 27, 2024
Merged

Fix lookup in SPTree #2759

merged 3 commits into from Feb 27, 2024

Conversation

alkino
Copy link
Member

@alkino alkino commented Feb 22, 2024

No description provided.

@alkino alkino requested a review from nrnhines February 22, 2024 14:08
@alkino alkino marked this pull request as ready for review February 22, 2024 14:40
Copy link

✔️ 4e9742e -> Azure artifacts URL

Copy link
Contributor

NEURON ModelDB CI: launching for 4e9742e via its drop url

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 66.31%. Comparing base (ed09605) to head (bbeef5a).

Files Patch % Lines
src/nrncvode/sptree.hpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2759   +/-   ##
=======================================
  Coverage   66.30%   66.31%           
=======================================
  Files         558      558           
  Lines      103970   103970           
=======================================
+ Hits        68942    68945    +3     
+ Misses      35028    35025    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nrnhines
Copy link
Member

Is this change covered in tests? I don't see a coverage report.

@alkino
Copy link
Member Author

alkino commented Feb 22, 2024

Is this change covered in tests? I don't see a coverage report.

No, it seems not, I can add one, but it seems to break the modeldb-ci

src/nrncvode/sptree.hpp Show resolved Hide resolved
@nrnhines
Copy link
Member

I don't understand how you got External CIs / nrn-modeldb-ci / nrn-modeldb-ci (pull_request) Failing after 126m to become part of the CI.

@nrnhines
Copy link
Member

alkino added the nrn-modeldb-ci-nightly label 2 hours ago

I was unaware of that. Very useful!

Copy link

sonarcloud bot commented Feb 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

✔️ bbeef5a -> Azure artifacts URL

@alkino
Copy link
Member Author

alkino commented Feb 27, 2024

In fact the failing models are the same that the one in master...

@alkino alkino merged commit 082d447 into master Feb 27, 2024
36 checks passed
@alkino alkino deleted the cornu/fix_sptree branch February 27, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants