Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs issue on release 8.2 #2739

Merged
merged 1 commit into from Feb 22, 2024
Merged

Fix docs issue on release 8.2 #2739

merged 1 commit into from Feb 22, 2024

Conversation

JCGoran
Copy link
Contributor

@JCGoran JCGoran commented Feb 14, 2024

Backport of #2229 that fixes #2710, at least on RTD (see https://readthedocs.org/projects/nrn/builds/23439484/).
Locally the issue still persists so I am inclined to keep that issue open in case someone wants to debug it thoroughly.

* Fix for dynamic ECS diffusion characteristics.

* Update extracellular.ipynb
Copy link

sonarcloud bot commented Feb 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (1d87d5d) 46.51% compared to head (2219c40) 46.56%.
Report is 1 commits behind head on release/8.2.

Files Patch % Lines
share/lib/python/neuron/rxd/species.py 44.44% 10 Missing ⚠️
share/lib/python/neuron/rxd/region.py 50.00% 4 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release/8.2    #2739      +/-   ##
===============================================
+ Coverage        46.51%   46.56%   +0.04%     
===============================================
  Files              527      527              
  Lines           119267   119282      +15     
===============================================
+ Hits             55474    55540      +66     
+ Misses           63793    63742      -51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

✔️ 2219c40 -> Azure artifacts URL

@pramodk pramodk merged commit 002594e into release/8.2 Feb 22, 2024
38 of 39 checks passed
@pramodk pramodk deleted the jelic/fix_docs branch February 22, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants