Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround for #2710 #2711

Merged
merged 3 commits into from Feb 8, 2024
Merged

Add workaround for #2710 #2711

merged 3 commits into from Feb 8, 2024

Conversation

JCGoran
Copy link
Contributor

@JCGoran JCGoran commented Feb 7, 2024

Workaround for #2710. The whole subsection "Initial conditions" has been removed to make the RTD build succeed, see: https://readthedocs.org/projects/nrn/builds/23371376/

@pramodk
Copy link
Member

pramodk commented Feb 7, 2024

@JCGoran : one question, with the 8.2.3 tag, locally you were able to reproduce the same problem? I got once but then things didn't work (my env was broken).

Above question is just to confirm if the issue existed in 8.2.3 or new in 8.2.4.

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b4c5480) 46.51% compared to head (13cb485) 46.50%.
Report is 2 commits behind head on release/8.2.

Additional details and impacted files
@@               Coverage Diff               @@
##           release/8.2    #2711      +/-   ##
===============================================
- Coverage        46.51%   46.50%   -0.01%     
===============================================
  Files              527      527              
  Lines           119267   119267              
===============================================
- Hits             55474    55471       -3     
- Misses           63793    63796       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

✔️ a5e4830 -> Azure artifacts URL

@JCGoran
Copy link
Contributor Author

JCGoran commented Feb 7, 2024

@pramodk I can confirm that 8.2.3 is also affected, I've tried using Python 3.11 locally, and get the exact same error. It's also reproducible on RTD: https://readthedocs.org/projects/nrn/builds/23370630/

@JCGoran JCGoran requested a review from pramodk February 7, 2024 09:33
@JCGoran
Copy link
Contributor Author

JCGoran commented Feb 7, 2024

RTD still complains though: https://readthedocs.org/projects/nrn/builds/23370582/

@JCGoran JCGoran marked this pull request as draft February 7, 2024 09:35
@JCGoran
Copy link
Contributor Author

JCGoran commented Feb 7, 2024

Converted to draft until I figure out how to make it work both on RTD and locally.

@pramodk
Copy link
Member

pramodk commented Feb 7, 2024

@pramodk I can confirm that 8.2.3 is also affected, I've tried using Python 3.11 locally, and get the exact same error. It's also reproducible on RTD: https://readthedocs.org/projects/nrn/builds/23370630/

That's good then. We can ask Robert / Adam about this in #2710.

Copy link

sonarcloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@JCGoran JCGoran marked this pull request as ready for review February 7, 2024 10:33
Copy link

✔️ 13cb485 -> Azure artifacts URL

@JCGoran JCGoran merged commit 2b4e13f into release/8.2 Feb 8, 2024
36 of 37 checks passed
@JCGoran JCGoran deleted the jelic/notebook_workaround branch February 8, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants