Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move random to src/gnu #2689

Merged
merged 14 commits into from Jan 27, 2024
Merged

Move random to src/gnu #2689

merged 14 commits into from Jan 27, 2024

Conversation

alkino
Copy link
Member

@alkino alkino commented Jan 25, 2024

This patch move most of the code that is not hoc to the directory gnu.

In the future this directory will be cleaned to remove gnu stuff and renamed something like 'src/random'.

This way nrn will have an external random library, and a clean hoc_interface.

This patch move Isaac, MCellRan4, Random123, Rand.

Base automatically changed from cornu/modern_nrnran123 to master January 25, 2024 22:35
@bbpbuildbot

This comment has been minimized.

@bbpbuildbot

This comment has been minimized.

@bbpbuildbot

This comment has been minimized.

Copy link
Contributor

Unable to retrieve AZURE drop url from comments!

@bbpbuildbot

This comment has been minimized.

Copy link

✔️ 7e94c47 -> Azure artifacts URL

Copy link
Contributor

NEURON ModelDB CI: launching for 7e94c47 via its drop url

Copy link

✔️ 756d18e -> Azure artifacts URL

Copy link
Contributor

NEURON ModelDB CI: 7e94c47 -> download reports from here

@bbpbuildbot

This comment has been minimized.

Copy link

sonarcloud bot commented Jan 26, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (f64b609) 66.32% compared to head (c57bbe4) 66.29%.

Files Patch % Lines
src/oc/oc_mcran4.cpp 39.28% 17 Missing ⚠️
src/ivoc/ivocrand.cpp 0.00% 13 Missing ⚠️
src/gnu/NrnRandom123RNG.hpp 61.53% 5 Missing ⚠️
src/gnu/Isaac64RNG.hpp 0.00% 2 Missing ⚠️
src/oc/scoprand.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2689      +/-   ##
==========================================
- Coverage   66.32%   66.29%   -0.04%     
==========================================
  Files         559      558       -1     
  Lines      108657   108431     -226     
==========================================
- Hits        72071    71886     -185     
+ Misses      36586    36545      -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

NEURON ModelDB CI: launching for 756d18e via its drop url

Copy link

✔️ c57bbe4 -> Azure artifacts URL

Copy link
Contributor

NEURON ModelDB CI: 756d18e -> download reports from here

@alkino
Copy link
Member Author

alkino commented Jan 27, 2024

nrn-modeldb-ci got no differences at all

Copy link
Member

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @alkino !

@pramodk pramodk merged commit 08920e7 into master Jan 27, 2024
39 of 40 checks passed
@pramodk pramodk deleted the cornu/move_rng_gnu branch January 27, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants