Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Random123 instead of Isaac64, ACG and MLCG #2674

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Use Random123 instead of Isaac64, ACG and MLCG #2674

wants to merge 14 commits into from

Conversation

alkino
Copy link
Member

@alkino alkino commented Jan 18, 2024 •
edited

Remove usage of:

  • Isaac64
  • ACG
  • MLCG

@codecov Codecov
Copy link

codecov bot commented Jan 18, 2024 •
edited

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (17bd2c8) 66.23% compared to head (76d3d1d) 66.26%.

Files Patch % Lines
src/ivoc/ivocrand.cpp 62.50% 15 Missing ⚠️
src/nrniv/multisend_setup.cpp 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2674      +/-   ##
==========================================
+ Coverage   66.23%   66.26%   +0.02%     
==========================================
  Files         559      557       -2     
  Lines      104008   103950      -58     
==========================================
- Hits        68890    68881       -9     
+ Misses      35118    35069      -49

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines Azure Pipelines
Copy link

✔️ af57bd1 -> Azure artifacts URL

@azure-pipelines Azure Pipelines
Copy link

✔️ a5507cc -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@alkino alkino marked this pull request as draft January 22, 2024 21:19
@bbpbuildbot

This comment has been minimized.

Sign in to view
@bbpbuildbot

This comment has been minimized.

Sign in to view
@alkino alkino changed the title Move all RNG to src/gnu Use Random123 as unique RNG Jan 31, 2024
@alkino alkino marked this pull request as ready for review January 31, 2024 17:55
@bbpbuildbot

This comment has been minimized.

Sign in to view
@pramodk
Copy link
Member

pramodk commented Feb 1, 2024

@alkino : I was reviewing Michael's comment during last meeting (recording here @ time 17:20). He confirmed removal of 1) Isaac64 2) ACG 3) MLCG.

So I was thinking the steps could be following:

  • A PR to remove 1) Isaac64 2) ACG 3) MLCG
    • launch the modelDB CI
    • hopefully there won't be many neuron tests or ModelDB models CI failures as these are not used much (?)
    • if any tests are using those then fix the tests to use Random123.
    • Michael will look into ModelDB CI failures, convert them to Random123 and validate results
  • Along with the above PR, create a PR to release/8.2 branch adding warning if user try to instantiation any of the above 3
  • Create separate PR for updating MCellRan4 to use Random123 underneath (i.e. we keep API)
    • same CI checks as above.
    • As MCellRan4 might have been used at more places, there might be a bit more work. But Michael has offered help to validate & convert models with Random123.

So considering the above, I am wondering if it is possible to split the removal of the above 3 RNs in one PR and MCellRan4 into another one. My "hope" is that the removal of the above 3 should be straightforward / less or no CI failures and hence can be merged faster.

@ohm314 ohm314 changed the title Use Random123 as unique RNG Use Random123 as the only RNG Feb 1, 2024
@alkino alkino changed the title Use Random123 as the only RNG Use Random123 instead of Isaac64, ACG and MLCG Feb 1, 2024
@bbpbuildbot

This comment has been minimized.

Sign in to view
@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines Azure Pipelines
Copy link

✔️ efbf7c5 -> Azure artifacts URL

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 1, 2024

NEURON ModelDB CI: launching for efbf7c5 via its drop url

alkino
alkino commented Feb 1, 2024
View reviewed changes
src/gnu/Rand.cpp
#include "Normal.h"

Rand::Rand(unsigned long seed, int size, Object* obj) {
// printf("Rand\n");
gen = new ACG(seed, size);
gen = new NrnRandom123(seed, size);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit weird, what do you think about that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure implications. lets discuss with Michael.

@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines Azure Pipelines
Copy link

✔️ f48accb -> Azure artifacts URL

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 9, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@azure-pipelines Azure Pipelines
Copy link

✔️ 76d3d1d -> Azure artifacts URL

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #192359 (:white_check_mark:) have been uploaded here!

Status and direct links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pramodk pramodk pramodk left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alkino @bbpbuildbot @pramodk