Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform cythonize() in build directory instead of source tree #2662

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

pramodk
Copy link
Member

@pramodk pramodk commented Jan 12, 2024

  • previously generates .cpp files in source tree. To have clean builds, move those in build dir
  • remove unnecessary includes for some cython extensions

- previously generates .cpp files in source tree. To have clean
  builds, move those in build dir
- remove unnecessary includes for some cython extensions
@pramodk pramodk marked this pull request as draft January 12, 2024 10:54
@bbpbuildbot

This comment has been minimized.

@bbpbuildbot

This comment has been minimized.

Copy link

sonarcloud bot commented Jan 29, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (128c684) 66.30% compared to head (608a74e) 66.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2662      +/-   ##
==========================================
- Coverage   66.30%   66.30%   -0.01%     
==========================================
  Files         558      558              
  Lines      108434   108425       -9     
==========================================
- Hits        71899    71892       -7     
+ Misses      36535    36533       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nrnhines nrnhines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea behind this. Why is it a work in progress? Because setup.py is going away?

@JCGoran
Copy link
Contributor

JCGoran commented Apr 12, 2024

This is a welcome change, but if we want to move away from setup.py in the long run, I think it would be better to make a CMakeLists.txt for both RX3D and MUSIC modules, as then we do not depend on setup.py at all.
For this, we can use the cython CLI command to convert the .pyx files to .cpp ones, after which we can create a shared library using standard CMake tooling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants