New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perform cythonize() in build directory instead of source tree #2662
base: master
Are you sure you want to change the base?
Conversation
pramodk
commented
Jan 12, 2024
- previously generates .cpp files in source tree. To have clean builds, move those in build dir
- remove unnecessary includes for some cython extensions
- previously generates .cpp files in source tree. To have clean builds, move those in build dir - remove unnecessary includes for some cython extensions
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2662 +/- ##
==========================================
- Coverage 66.30% 66.30% -0.01%
==========================================
Files 558 558
Lines 108434 108425 -9
==========================================
- Hits 71899 71892 -7
+ Misses 36535 36533 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea behind this. Why is it a work in progress? Because setup.py is going away?
This is a welcome change, but if we want to move away from |