Add support to delete SHM File Transfer files while simulation loads #2644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiorg-hpc
force-pushed
the
srivas/shm_delete
branch
from
902b51a
to
f4990e8
Compare
1uc
reviewed
Dec 18, 2023
|
✔️ f4990e8 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
|
✔️ 091bdad -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2644 +/- ##
==========================================
- Coverage 66.20% 66.19% -0.01%
==========================================
Files 559 559
Lines 108957 108963 +6
==========================================
+ Hits 72132 72133 +1
- Misses 36825 36830 +5 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
|
|
✔️ dfed263 -> Azure artifacts URL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proposed change allows us to reduce the memory pressure while the simulation loads with CoreNEURON and the SHM File Transfer is active. The new behaviour is to delete the input files as soon as they are read. Thus, effectively allowing the simulator to use more memory in big simulations.