Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolves restructuring caused by find_parent_seg #2593

Merged
merged 2 commits into from Oct 26, 2023
Merged

Resolves restructuring caused by find_parent_seg #2593

merged 2 commits into from Oct 26, 2023

Conversation

rgourdine
Copy link
Collaborator

closes #1115

@rgourdine rgourdine self-assigned this Oct 25, 2023
@rgourdine rgourdine added the rxd reaction-diffusion label Oct 25, 2023
@azure-pipelines
Copy link

✔️ 0922679 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
ramcdougal
ramcdougal approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@ramcdougal ramcdougal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to remove the numpy dependency, but othertwise looks good.

@ramcdougal ramcdougal enabled auto-merge (squash) October 26, 2023 00:53
@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@azure-pipelines
Copy link

✔️ 8e56a39 -> Azure artifacts URL

@ramcdougal ramcdougal merged commit a8a0060 into master Oct 26, 2023
32 of 34 checks passed
@ramcdougal ramcdougal deleted the update_find_parent_seg branch October 26, 2023 01:50
@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #164985 (:no_entry:) have been uploaded here!

Status and direct links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramcdougal ramcdougal ramcdougal approved these changes

Assignees

@rgourdine rgourdine

Labels
rxd reaction-diffusion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

find_parent_seg uses h.distance(pt) not h.distance(pt1, pt2) possibly corrupting base point
3 participants
@rgourdine @bbpbuildbot @ramcdougal