-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Sprintf
of data handle.
#2509
Conversation
One could discuss if this should really print the address of a pointer, or the string representation of a |
The context of this change is: #2499. There |
✔️ 828aec7 -> Azure artifacts URL |
Codecov Report
@@ Coverage Diff @@
## master #2509 +/- ##
==========================================
- Coverage 61.48% 61.48% -0.01%
==========================================
Files 623 623
Lines 119154 119159 +5
==========================================
- Hits 73263 73259 -4
- Misses 45891 45900 +9
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I wonder if it’s later but @iomaganaris might know better. |
It's just a matter of picking what should be displayed in a comment in a generated HOC command/script. |
@nrnhines would you like it to print a pointer address or modernize further to make it read something like:
where the first |
Let's do this. |
✔️ d23dafa -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
✔️ 579e630 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
Sprintf
via static_cast<double*>
.Sprintf
of data handle.
✔️ e99c1b9 -> Azure artifacts URL |
If
data_handle
were non-trivial, then Mac CI complains that it can't pass a non-trivial type tostd::snprintf
. However, given the string, it seems like a bug, and we should be printing the address of a pointer.