Remove checks that were making defines that weren't used. #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* For instance `HAVE_FCNTL_H` is never checked for in the code
* This speeds up cmake configuration on my machine by ~25% to ~30%
Before:
1.76user 0.61system 0:02.35elapsed 100%CPU (0avgtext+0avgdata 22996maxresident)k
After:
1.14user 0.34system 0:01.45elapsed 102%CPU (0avgtext+0avgdata 23056maxresident)k
matz-e
approved these changes
Apr 16, 2024
|
I can't add reviewers, perhaps @nrnhines should have a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For instance
HAVE_FCNTL_His never checked for in the codeThis speeds up cmake configuration on my machine by ~25% to ~30%
Before: 1.76user 0.61system 0:02.35elapsed 100%CPU (0avgtext+0avgdata 22996maxresident)k
After: 1.14user 0.34system 0:01.45elapsed 102%CPU (0avgtext+0avgdata 23056maxresident)k