Latte: fixed adding dynamic snippets to payload #1358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When static snippet wrapper (or snippetArea) contained a dynamic snippet wrapped in a block (i.e. static snippet -> block -> dynamic snippet), rendered dynamic snippets weren't added into payload. Cause was that information was shared via scope which was different for nested block (block is a function call) and snippet wrapper. Fix was done via shared reference to a stdClass object.
|
Add a test and fix existing ones. |
|
OK, I will do it, however, it may take some time till I get down to it. |
dg
force-pushed
the
master
branch
3 times, most recently
from
991ba1a
to
e23de7a
Compare
|
@matej21 what do you think about this? |
|
@dg looks ok to me |
dg
force-pushed
the
master
branch
2 times, most recently
from
489cca2
to
0b969cd
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
09a7d92
to
b9698a8
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
5a8c108
to
3aa3147
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
5feee0e
to
3fc1e40
Compare
dg
force-pushed
the
master
branch
5 times, most recently
from
688f189
to
1bc9d13
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
7215ae6
to
71b2047
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When static snippet wrapper (or snippetArea) contained a dynamic
snippet wrapped in a block (i.e. static snippet -> block -> dynamic
snippet), rendered dynamic snippets weren't added into payload.
Cause was that information was shared via scope which was different for
nested block (block is a function call) and snippet wrapper.
Fix was done via shared reference to a stdClass object.