FileStorage: set permissions of files and directories

[fabik]

I am still having troubles with issue #1039. It was closed because of umask() problems, but nobody mentioned chmod(). Why cannot FileStorage just get file and directory mode as optional constructor parameters and change file permissions itself?

So, for instance

$storage = new FileStorage($dir, $journal, 0664, 0775);

would call chmod(..., 0664) on all created files and mkdir(..., 0775) on created dirs.

There would be no problems with thread safety as in the case of umask(), or am I wrong?

[JanTvrdik]

But both chmod and mkdir respects umask setting. So if umask is wrong, using chmod won't make a difference. Or am I wrong?

[fabik]

I don't think so. I've tried this code

umask(0777);
$file = __DIR__ . '/test.txt';
touch($file);
chmod($file, 0777);

and it worked, so the example in the PHP doc doesn't make sense to me.

[milo]

umask() only restricts default values in fopen(), mkdir() and similar. Default value for files is 0666, for directories 0777. If you call chmod(), you set exactly the permissions which you wish.

But for mkdir() it is quite tricky.

mkdir('test1'); # depends on system umask

umask(0777);
mkdir('test2'); # depends on PHP's umask
mkdir('test3', 0666); # still depends on PHP's umask, even mode is specified

So chmod() shoud be always called if exact permissions are required.

[milo]

@fabik Yes, that PHP example is wrong. They should use mkdir() instead of chmod().

[fabik]

Well, that's great! I'll create a pull request that adds chmod() to FileStorage.

[dg]

Is it really needed to configure permissions?

[fabik]

I use the same cache storage for web and its CLI. The web server runs on a different user than CLI, but both users are in the same group. So, I would like to set the permissions of the cached files to 0664 and directories to 0775.

[fprochazka]

Hey, I had to change the http server to run under my user on dev mashine to have no problems in CLI. And on production I have to login as the httpserver user... But I guess it is more secure this way.

[fabik]

Yes, it is more secure. For instance, the CLI user has access to the backup directory, which I don't want to be accessible via web server user.