Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support offline installs in the updater code. #17648

Merged
merged 1 commit into from
May 15, 2024

Conversation

Ferroin
Copy link
Member

@Ferroin Ferroin commented May 13, 2024

Summary

Add limited support for offline installs to the updater code.

This allows use of a prepared offline install source to update an existing offline install by simply following the usual offline installation instructions, instead of needing to manually specify the --reinstall option to run an update. This particular implementation has a couple of specific limitations:

  • It only works if the current version of the offline install includes the changes in this PR. This is because the updater script in an offline install cannot update itself, and thus is stuck with whatever functionality it had when installed.
  • It does not support version comparison. There is little benefit to having support for this, and not implementing it significantly simplifies the code.
  • The offline install source still must be manually prepared.
Test Plan

This requires manual testing with some special effort involved.

Steps to test:

  1. Create a ‘normal’ offline install.
  2. Replace the updater script (/opt/netdata/usr/libexec/netdata/netdata-updater.sh) with the updater script from this PR.
  3. Prepare a new offline install source using the kickstart script from this PR.
  4. Use the offline install source from step 3 to install on the same system where the offline install in step 1 was installed.

Attempting the above procedure either without step 2, or with step 3 using the currently published kickstart script instead of the one from this PR should cause a failure in the update process in step 4.

@github-actions github-actions bot added the area/packaging Packaging and operating systems support label May 13, 2024
@Ferroin Ferroin marked this pull request as ready for review May 14, 2024 11:39
@Ferroin Ferroin requested a review from a team as a code owner May 14, 2024 11:39
@Ferroin Ferroin merged commit 002c951 into netdata:master May 15, 2024
150 of 151 checks passed
@Ferroin Ferroin deleted the updater-offline branch May 15, 2024 11:59
@Ferroin Ferroin mentioned this pull request May 17, 2024
Ferroin added a commit to stelfrag/netdata that referenced this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/packaging Packaging and operating systems support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant