Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional loadBalancerClass in service spec #171

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

vabrams
Copy link

@vabrams vabrams commented Dec 8, 2023

To use another load balancer class, we need the ability to specify LoadBalancerClass for services

To use another load balancer class, we need the ability to specify LoadBalancerClass for services
@RangerRick
Copy link
Contributor

@vabrams Hey, I'm taking over maintainership and going through old PRs. Just a couple of comments on this one:

  1. The directory layout has gone through some rearranging since this PR was made, mind rebasing so it's pointing at the new location of service.yaml?
  2. Do you mind adding the property to the values.yaml and README.md as well so it's documented alongside the other load balancer values?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants