add ability to inject secrets in the pods #163
+22
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imdhruva
changed the title
bootc
requested changes
Oct 31, 2023
Comment on lines
+68
to
+69
| _load_yaml() | ||
|
|
Comment on lines
+371
to
+372
| | `housekeeping.args`. | Custom start up arguments for netbox container arguments. | `[]` | | ||
| | `housekeeping.command` | Custom container entrypoint. | ["/opt/netbox/venv/bin/python","/opt/netbox/netbox/manage.py",rqworker] | |
There was a problem hiding this comment.
Nitpick: can you please swap these two lines? Logically I feel like that makes more sense as the args are appended to the command when both are present.
Comment on lines
+699
to
+700
| args: [] | ||
| command: |
There was a problem hiding this comment.
Same as the above, could we swap these around please?
Comment on lines
+783
to
+784
| args: [] | ||
| command: |
There was a problem hiding this comment.
Same as the above, could we swap these around please?
bootc
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issues is attempt to enable injecting of secrets via vault or other such tools. The issue is described here: #160.
With this change we can
consul-template -exec "/opt/netbox/venv/bin/python /opt/netbox/netbox/manage.py rqworkerat the entrypoint so vault can managed injection of the extra secrets./run/config/extra/vault/secrets.yaml/run/config/extra/vault/secrets.yamland override the previously read the secetsLet me know if this makes sense.