Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to extend configuration.py #155

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

rsmithcooper
Copy link

@rsmithcooper rsmithcooper commented Jun 27, 2023

This gives the ability to extend the configuration.py file populated by the configMap.

Use case: adding an Okta OIDC integration using the social-auth library.

current workaround: editing the configmap manually after helm install and then redeploying the deployment

@bootc
Copy link
Member

bootc commented Oct 31, 2023

I don't have an issue with adding a mechanism for adding Python config code, but you shouldn't need this to add static configuration values—you can do that with the extraConfig setting. Do you need to be able to run actual Python code rather than just setting static values? If so you'd probably be better off using extraVolumeMounts and extraVolumes to mount your Python script into /etc/netbox/config/...

@bootc bootc added enhancement New feature or request more info More information required from the reporter labels Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request more info More information required from the reporter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants