fix(float): missing default highlight for title #28617
Merged
+27
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm also not sure if this is desired. This is not backward-compatible with v0.9. |
|
When no highlight is configured in chunk , assume they use the default title highlight like string. |
justinmk
reviewed
May 3, 2024
bfredl
reviewed
May 10, 2024
zeertzjq
reviewed
May 11, 2024
glepnir
force-pushed
the
border_hl
branch
2 times, most recently
from
c1b6c43
to
d26d42c
Compare
zeertzjq
reviewed
May 12, 2024
glepnir
force-pushed
the
border_hl
branch
3 times, most recently
from
b1a164c
to
38c1b1a
Compare
bfredl
reviewed
May 25, 2024
|
Togheter with this change, we could get rid of |
Problem: there is missing default title highlight when highlight not defined in title text chunk. Solution: when attr is not set use default title highlight group.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: there is missing default title highlight when highlight not defined in title text chunk.
Solution: when attr is not set use default title highlight group.