Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use np-conv2d from PyPI #1686

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Use np-conv2d from PyPI #1686

wants to merge 1 commit into from

Conversation

tbekolay
Copy link
Member

Motivation and context:
We've been collaborating with @renmengye on the https://github.com/renmengye/np-conv2d project. When some PRs that we've made are merged and released, it will be easier maintenance-wise to use that project directly rather than including it in our source.

How has this been tested?
Tested with existing tests.

How long should this take to review?

  • Quick (less than 40 lines changed or changes are straightforward)

Types of changes:

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have read the CONTRIBUTING.rst document.
  • [na] I have updated the documentation accordingly.
  • [na] I have included a changelog entry.
  • [na] I have added tests to cover my changes.
  • I have run the test suite locally and all tests passed.

Still to do:
This PR is waiting on the np-conv2d project to be release on PyPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant