Reset op resets to initial signal value #1652
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context:
When I was preparing the 3.1 release, I found that a slow test was failing. To fix it, I added a
Reset
op, which required resetting the value to a two-dimensional value instead of a scalar. Rather than deal with that, I though it made more sense to haveReset
reset signals to their initial values, whatever they may be.In the end, I went with another approach to fix the slow test failure, but this PR still seems like a useful one to have IMO.
How has this been tested?
Existing tests cover it.
How long should this take to review?
Types of changes:
Checklist:
Still to do: