LinearSystem and related changes from Nengolib #1650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And move them to `_vendor/scipy/signal`. This both makes it clearer that these functions come from Scipy, and makes it easier to update them because they are ignored for static checks/coverage tests. The version of Scipy used, and modifications made, are noted at the top of each file.
This allows arbitrary shapes to be used, since `np.dot` operates on the last dimension (the other dimensions are unchanged).
This network implements an arbitrary LinearSystem in neurons using an arbitrary synapse.
This demonstrates the use of a more advanced Principle 3 technique that avoids needing to filter the output (or state) of the LinearSystemNetwork. Also moved nrmse to utils/testing.py since it was used by multiple tests.
This allows new (potentially modified) FrozenObjects to be created.
hunse
force-pushed
the
nengolib-linearsystem
branch
from
c2a12ae
to
53099c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context:
This is essentially a copy of #1611 that has been rebased to master. There are still some things left to do (static checks are failing, for example) but we decided to move the LinearSystem and other Synapse changes to a separate PR so that we could get Nengo 3.1 released soon.
Interactions with other PRs:
Based on #1611.
How long should this take to review?
Types of changes:
Checklist:
Still to do: