Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for Simulator.clear_probes #1637

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add test for Simulator.clear_probes #1637

wants to merge 1 commit into from

Conversation

hunse
Copy link
Collaborator

@hunse hunse commented Sep 1, 2020

Motivation and context:

Simulator.clear_probes is not tested explicitly, so it's not required that backends implement it. This adds a test, which will prompt backends to implement this (though they can still explicitly opt out by skipping the test, of course).

How long should this take to review?

  • Quick (less than 40 lines changed or changes are straightforward)

Types of changes:

  • Non-code change (touches things like tests, documentation, build scripts)

Checklist:

  • I have read the CONTRIBUTING.rst document.
  • I have updated the documentation accordingly.
  • I have included a changelog entry.
  • I have added tests to cover my changes.
  • I have run the test suite locally and all tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant