Support defaults in FrozenObjects #1618
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added tests for processes, solvers, transforms, and learning rules
This commit also fixes a bug in FrozenObject.__repr__ for arguments that were being passed `Default`. previously they would always show up in the repr because the resolved default value is different from what shows up in the `defaults` dict, which will always be `nengo.Default`.
Previously, Default was only supported in NengoObject and LearningRuleType. In order to support it in more FrozenObject subclasses, we effectively wanted to add the SupportDefaultsMixin to FrozenObject; however, we needed a slight change in logic in FrozenObject, so we opted for a small amount of duplication to allow us to remove SupportDefaultsMixin. The previous behavior is now in NengoObject.__setattr__ and the slightly changed logic is in FrozenObject.__setattr__.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context:
In #1615, I noticed that
LearningRuleTypesupportsDefaultarguments, but no otherFrozenObjecttypes do. Since it seems like they should, I moved that ability to theFrozenObjectclass, and made use of that ability in all the subclasses.A few side effects / cleanups done in the process were to remove the
SupportDefaultsMixinand to move theFrozenObjecttobase.py.Interactions with other PRs:
Based on #1615.
How has this been tested?
All unit tests passed without modification.
How long should this take to review?
Where should a reviewer start?
Probably go commit by commit, the last commit has the biggest diff but is the smallest conceptual change.
Types of changes:
Checklist:
Still to do:
Still need to do changelog entries, but wanted to make sure people think this is a good idea before writing it.