Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting and Pytests #63

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Formatting and Pytests #63

wants to merge 5 commits into from

Conversation

maxmarzolf
Copy link

  • Added urllib3 to requirements.txt
  • Abbreviated props dictionary creation as dictionary literal in utility.py
  • Fixed typo in get_explanation function
  • Made formatting PEP 8 compliant

- Added urllib3 to requirements.txt
- Abbreviated props dictionary creation as dictionary literal in utility.py
- Fixed typo in get_explanation function
- Made formatting PEP 8 compliant
@maxmarzolf maxmarzolf changed the title Mostly formatting Formatting and Pytests Jun 8, 2021
@JustinGOSSES
Copy link
Contributor

Can you explain all the changes to the requirements.txt file. It isn't just the addition of urllib3.

@maxmarzolf
Copy link
Author

Can you explain all the changes to the requirements.txt file. It isn't just the addition of urllib3.

hmm I only intended to add urllib3, not sure why more than that was changed :)

Removing unnecessary packages unique to my environment.
@maxmarzolf
Copy link
Author

Would be happy to put more work in, thanks.

@tejusp
Copy link

tejusp commented Aug 28, 2022

Can you explain all the changes to the requirements.txt file. It isn't just the addition of urllib3.

hmm I only intended to add urllib3, not sure why more than that was changed :)

This PR has been open for more than 1.5 years. Is it still relevant ?

@maxmarzolf
Copy link
Author

Can you explain all the changes to the requirements.txt file. It isn't just the addition of urllib3.

hmm I only intended to add urllib3, not sure why more than that was changed :)

This PR has been open for more than 1.5 years. Is it still relevant ?

I think so, the last sentence in the readme says, "If you would like to contribute, right now we could use some attention to the tests." which is what this PR aims to develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants