Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
this implements a very simple print function and closes #888.
There are still some issues with this, therefore I'm asking for comments.
The print settings are being reset each time the user creates a new or loads an existing document. For the first printing, the documents dimensions and resolution are compared to those of the printer's default document size.
If the document fits onto a single printer's page, it is scaled at the default 100%, even if that results in a small document printed on an mostly empty page.
If the document dimensions and resolution are too large, printing is scaled down accordingly to fit a single page.
If the user decides to use a different scaling factor or printer document size, the document will be tiled on as many printer pages as needed for the user's desired settings.
The print settings are then stored for the document and will be reused for the next call to the print function. If the user has made the document larger by then, the printing will be tiled accordingly.
Here are the issues where I request help/feedback.
Ctrl
+P
doesn't work as I would expect from reading the code, it will activate theTogglePreviewTool
instead and I haven't found out why.