Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add width and baseline properties documentation #3358

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

StefRe
Copy link
Contributor

@StefRe StefRe commented May 9, 2023

  • add Width property class
  • fix links for baseline and width properties (Area, Bar, Bars, Dash)

current documentation contains undefined links:
grafik

The baseline property just needed a link to Coordinate properties. For the width property I created a new IntervalProperty class and added the corresponding section to the properties tutorial:
grafik

I couldn't think of any meaningful test, so I'm afraid test coverage will slightly decrease.


I noticed that the legend and normed class variables are defined without a leading underscore, but the Offset and FontSize classes use _legend:

class Offset(IntervalProperty):
"""Offset for edge-aligned text, in point units."""
_default_range = 0, 5
_legend = False
class FontSize(IntervalProperty):
"""Font size for textual marks, in points."""
_legend = False

I have stuck to the variant without underscore as defined in the base class in this PR.

- add Width property class
- fix links for baseline and width properties (Area, Bar, Bars, Dash)
@StefRe StefRe marked this pull request as draft May 9, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant