Fixes to system text and system text lines (#22811) #22866
+54
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| spanner->styleChanged(); | ||
| score->cmdAddSpanner(spanner, i, startSegment, endSegment, modifiers & Qt::ControlModifier); | ||
| mu::engraving::Spanner* s = static_cast<mu::engraving::Spanner*>(engraving::Factory::createItem(type, score->dummy())); | ||
| rw::RWRegister::reader()->readItem(s, e); |
There was a problem hiding this comment.
Except for consistency, does this change have a specific effect? If not, I'm not sure how nice this is, because going via mime data is definitely less efficient than just cloning directly
There was a problem hiding this comment.
Partly consistency, partly the fact that cloning doesn't seem to produce a text line with "system" style (e.g. font size). Unsure why this is the case, I'll look into it.
There was a problem hiding this comment.
Alright @cbjeukendrup - just pushed a different approach using clones & fixed the unit tests.
mathesoncalum
force-pushed
the
22811-system_text_staff
branch
3 times, most recently
from
e8436cf
to
b9200da
Compare
mathesoncalum
force-pushed
the
22811-system_text_staff
branch
from
b9200da
to
6a35bf0
Compare
mathesoncalum
force-pushed
the
22811-system_text_staff
branch
from
6a35bf0
to
f80b9fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #22811
While working on this issue I noticed that system text lines added to list selections and system text lines added to range selections had different font sizes. This is because, in the range case, the spanner was being initialised without the "system flag" and was being treated as a regular text line. This PR ensures that we use identical initialisations in both cases.
Additionally, the decision was made to change our default
systemTextFontSizeto 12pt, bringing it in-line withsystemTextLineFontSize. Whether these should be different styles at all is a question for another day (somewhat related to #14238).