Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply_sound_flag_to_all_staves_fix #22855

Conversation

RomanPudashkin
Copy link
Contributor

Resolves: #22707

@avvvvve
Copy link

avvvvve commented May 16, 2024

@RomanPudashkin Still testing but just found this auditioning issue:

  1. Apply a sound flag to one staff, turn "Apply selection to all staves" off.
  2. Apply another sound flag to a second staff on the same instrument some beats later. Turn "Apply selection to all staves" off.
  3. On the first staff, the "Ord. (default)" sound is played where the sound flag on the second staff begins when auditioning. It should still be playing as the sound flag on that staff.

@avvvvve
Copy link

avvvvve commented May 16, 2024

Not a problem, but just wanted to make note of how multiple sound flags at the same time with "Apply selection to all staves" turned on interact:

Create an instrument with 4 staves. Place different sound flags on staff 2 and staff 4 at the same beat position, leaving "Apply selection to all staves" turned on for both. Hear that the two staves without sound flags get the sound from staff 4.

It seems that the sound flag on the bottommost staff takes precedence over the other sound flag. The order the sound flags were applied doesn't matter.

@RomanPudashkin RomanPudashkin force-pushed the apply_sound_flag_to_all_staves_fix branch from 757f9da to d172b87 Compare May 17, 2024 12:59
@RomanPudashkin RomanPudashkin force-pushed the apply_sound_flag_to_all_staves_fix branch from d172b87 to b4fbb45 Compare May 17, 2024 13:02
@avvvvve
Copy link

avvvvve commented May 17, 2024

Tested & approved!

@RomanPudashkin RomanPudashkin merged commit eb9cbeb into musescore:master May 20, 2024
11 checks passed
@RomanPudashkin RomanPudashkin deleted the apply_sound_flag_to_all_staves_fix branch May 20, 2024 07:04
@RomanPudashkin RomanPudashkin mentioned this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants