Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: wrong Lilypond Lyrics plugin description #22833

Closed
wants to merge 1 commit into from

Conversation

Gootector
Copy link
Contributor

@Gootector Gootector commented May 15, 2024

In Home -> Plugins -> Lilypond Lyrics, MuseScore Studio shows wrong description: 'sTr("Apply lyrics in lilypond format."'
'qsTr()' is unnecessary here. The plugin descriptions are also without dot at the end.

Greetings,
Gootector

Resolves: #NNNNN

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

In Home -> Plugins -> LiLypond Lyrics, MuseScore Studio shows wrong description:
'sTr("Apply lyrics in lilypond format."'
'qsTr()' is unnecessary here. The descriptions are also without dots.

Greetings,
Gootector
@Gootector
Copy link
Contributor Author

Mmm... in this file:
{ - 108
} - 110?

@Jojo-Schmitz
Copy link
Contributor

I believe it is actually a bug that the description field of plugins is not translatable

@cbjeukendrup
Copy link
Contributor

'qsTr()' is unnecessary here.

Really? Right now, it doesn't do anything because the strings from plugins are not pushed to Transifex, but this is something we want to do in the future.

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented May 15, 2024

That's why I claim it to be a bug (in the Plugin API, not this particular plugin). it should just show the untranslated string (here: Apply lyrics in lilypond format.) rather than the (partial!) description property (here: sTr("Apply lyrics in lilypond format.")

@Gootector
Copy link
Contributor Author

This bug doesn't occur in 4.3.0, in Qt 5. So - should I close my PR?

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented May 16, 2024

Yes, I guees so. We'd need an issue opend on the non-translatability of the plugin description though

@Gootector Gootector closed this May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants