-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable certain properties when not needed #22603
base: master
Are you sure you want to change the base?
Conversation
Tested on MacOS 14, Windows 11, Ubuntu 22.04.3. Approved |
m_beginningTextOffset->setIsEnabled(hasBeginText); | ||
m_continuousTextOffset->setIsEnabled(hasContinueText); | ||
m_endTextOffset->setIsEnabled(hasEndText); | ||
m_gapBetweenTextAndLine->setIsEnabled(isLineAvailable && (hasBeginText || hasContinueText)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that #22602 has been merged:
m_gapBetweenTextAndLine->setIsEnabled(isLineAvailable && (hasBeginText || hasContinueText)); | |
m_gapBetweenTextAndLine->setIsEnabled(isLineAvailable && (hasBeginText || hasContinueText || hasEndText)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should that component visually be moved as well, maybe to the top or bottom of the text section? Up until now it made sense to keep it between begin and continue text because it only affected them, but now it affects all text types...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had forwarded the question above to @bkunda on Slack, but unless I missed something I hadn't heard back yet. I think it's indeed good to move this property but the question is of course where.
This PR disables the Text Offset option for text in line elements when there is no text to be offset. Additionally, the 'Gap between text and line' option is disabled when there is no text to leave a gap between.