-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/grain3d #2015
Open
ralfHielscher
wants to merge
374
commits into
develop
Choose a base branch
from
feature/grain3d
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/grain3d #2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
import wizard is still broken
# Conflicts: # VERSION # geometry/@symmetry/symmetry.m # interfaces/loadEBSD_h5oina.m
# Conflicts: # startup_mtex.m # tests/check_mex.m
Feature/grain3d
EulerCyclesC.c: only needs the number of points instead of the entire array Compile everything again (somehow an old version was still there)
Feature/grain3d
I think rotation.map in set.east/north etc. needs a second vector pair to define the correct rotation otherwise you can accidentally change the first screen direction when setting the other one in the constructor: pC = plottingConvention(vector3d.Z,-vector3d.X) % pC = plottingConvention % % outOfScreen: (0,0,-1) % north : (0,1,0) % east : (-1,0,0) pC.rot % ans = rotation % % Bunge Euler angles in degree % phi1 Phi phi2 % 90 180 270 pC.outOfScreen % ans = vector3d % x y z % 0 0 -1 % % this is wrong % try to set outOfScreen again pC.outOfScreen = vector3d.Z pC.rot % pC = plottingConvention % % outOfScreen: (0,0,1) % north : (0,-1,0) % east : (-1,0,0) % % ans = rotation % % Bunge Euler angles in degree % phi1 Phi phi2 % 180 0 0 pC.outOfScreen % ans = vector3d % x y z % 0 0 1 % this is now correct
fix plottingConvention.m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement full 3d support for MTEX
the following functions needs to be ported
pseudo3d EBSD
calcTraces
cat
should return EBSD3 if pixels are not within a single planeebsdSquare
andEBSDHex
should returngradientZ
curvature
should make use ofgradientZ
fill
fillByGrainId
findByLocation
gridify
should work also for maps in the xz and yz planeinpolygon
interp
reduce
selectInteractive
smooth
spatialProfile
calcUnitCell
weightedBurgersVector
pseudo3d in grain2d
checkInside
inpolygon
EBSD3
calcGrains
calcTraces
fill
fillByGrainId
findByLocation
gridify
interp
KAM
plot
plotUnitCells
reduce
smooth
slice
weightedBurgersVec
*EBSDcube
grain3d