-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRF head [WIP] #393
Open
singularperturbation
wants to merge
8
commits into
mratsim:master
Choose a base branch
from
singularperturbation:crf_head
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
CRF head [WIP] #393
singularperturbation
wants to merge
8
commits into
mratsim:master
from
singularperturbation:crf_head
Commits on Oct 22, 2019
-
Want to try and add a new CRF layer for sequence tagging / prediction, and will implement Viterbi decoding and NLL as the loss value.
Configuration menu - View commit details
-
Copy full SHA for b4f6825 - Browse repository at this point
Copy the full SHA b4f6825View commit details -
Add initializer function for transitions matrix
There is some logic needed to properly create the transitions matrix, so add an initializer function using range + xavier uniform, and disallow Any -> BOS or EOS -> Any transitions.
Configuration menu - View commit details
-
Copy full SHA for 177846d - Browse repository at this point
Copy the full SHA 177846dView commit details
Commits on Oct 23, 2019
-
Following other implementations, will do scores + log partition function for the forward pass (getting NLL).
Configuration menu - View commit details
-
Copy full SHA for c0c8ccd - Browse repository at this point
Copy the full SHA c0c8ccdView commit details
Commits on Oct 24, 2019
-
Add index_select with passed-in storage
Uses array passed in and only reshapes if needed (the new Tensor has a larger size than the old one). Needed / think should help when doing index_select with each subset of the same size. Example here is selecting batch_size for each time step in CRF emissions.
Configuration menu - View commit details
-
Copy full SHA for 7f8a272 - Browse repository at this point
Copy the full SHA 7f8a272View commit details -
Formatting and some API changes
Ran 'nimpretty' to clean up formatting / long lines, and passed more information to the nnp_crf functions.
Configuration menu - View commit details
-
Copy full SHA for 692c7d3 - Browse repository at this point
Copy the full SHA 692c7d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c597a4 - Browse repository at this point
Copy the full SHA 1c597a4View commit details -
Implementation of forward pass underway, starting with scores (non normalized log prob with emission + transition components).
Configuration menu - View commit details
-
Copy full SHA for 1db105e - Browse repository at this point
Copy the full SHA 1db105eView commit details
Commits on Oct 29, 2019
-
Fix some bugs with CRF non-normalized score calculation (mostly making sure that not returning matrix when shouldn't when using index_select). Also fix some out-of-bounds bug due to loop over time steps.
Configuration menu - View commit details
-
Copy full SHA for e618061 - Browse repository at this point
Copy the full SHA e618061View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.