Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats.lua: indent video and audio profile #14148

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

6ws
Copy link

@6ws 6ws commented May 15, 2024

Eliminates clutter by moving the profile into its own subsection.

@kasper93 kasper93 added priority:on-ice may be revisited later scripting:stats labels May 15, 2024
@kasper93
Copy link
Contributor

kasper93 commented May 15, 2024

Just like #13913 and #13866 it is blocked, because we don't have much vertical lines left. There was idea in #13913 to move all track related properties to new page and make page 1 only for stats. But exact split is also not clear to make it readable.

@6ws
Copy link
Author

6ws commented May 15, 2024

In this case, the profile shares the same line as the codec. I probably should have said indentation instead of subsection. Sorry about that!

Copy link

Download the artifacts for this pull request:

Windows
macOS

@kasper93
Copy link
Contributor

kasper93 commented May 15, 2024

Ah, I see what you did. In this case we can consider it. I didn't do that to not make this line too long. Maybe it is more readable though.

@kasper93 kasper93 removed the priority:on-ice may be revisited later label May 15, 2024
@6ws 6ws changed the title stats.lua: add video and audio profile stats.lua: indent video and audio profile May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants