Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add conf.toJson() method #407

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add conf.toJson() method #407

wants to merge 2 commits into from

Conversation

ath88
Copy link

@ath88 ath88 commented Oct 3, 2022

Resolves #406

It simply uses the implementation of toString, including the sensitivity-censoring. Also, it changes toString to use toJson to keep it more dry.

A test is added too.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 93.225% when pulling db9247c on ath88:add-tojson-method into 9ca2d82 on mozilla:master.

@coveralls
Copy link

coveralls commented Oct 3, 2022 •
edited

Coverage Status

Coverage increased (+0.02%) to 93.225% when pulling 4ce7882 on ath88:add-tojson-method into 9ca2d82 on mozilla:master.

@SidSethi
Copy link

SidSethi commented Nov 7, 2022

Thanks @ath88 for making this PR - would love to be able to use this function instead of what we currently do JSON.parse(conf.toString()

@ath88
Copy link
Author

ath88 commented Nov 16, 2022 •
edited

Any maintainers available for a quick gander at this menial PR? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: toJson-method
3 participants
@ath88 @coveralls @SidSethi