RAPTOR Pretrip fix #246
Open
RAPTOR Pretrip fix #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where the departure events where not correctly calculated when meta start stations are enabled for a pretrip search.
Previously, if a station was reachable by foot from the source station it would result in departure event timestamps reduced by the footpath length for the source station, as we have to walk from the source station.
If the station is also denoted as a meta station then we do NOT want the departure event timestamps reduced by the footpath length, as it is possible to directly start at the meta station.
This seems to be correct (tested for swiss gtfs), but still very slow while building the raptor timetable (~20s).