Do not show error dialog if quitAfter is set #977
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe the underlying issue causing lack of termination after dismissal of the error dialog has been fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If quitAfter is set for the session it will quit without trying to display the error dialog. The window was not visible when the dialog was displayed causing the Moonlight to stay running after the session ended.
The window could be set to be visible to display the error dialog however Sunshine returns an unexpected termination error when the app that the session is bound to is closed. Which would give you the error dialog every time you close the app to end the session. This is why I went with removing the error dialog instead of displaying it as the use case for this is launching directly into a session from the command line without the GUI.
Fix: #939